On Fri, 13 May 2011 18:37:01 +0800 jekyll <[email protected]> wrote:
> 2011/5/13 Jacob Pan <[email protected]> > > > On Thu, 12 May 2011 21:21:48 +0800 > > Jekyll Lai <[email protected]> wrote: > > > > > - pm_runtime_put_noidle(&pdev->dev); > > > + if (pci_dev_run_wake(&pdev->dev)) > > > + pm_runtime_put_noidle(&pdev->dev); > > > pm_runtime_allow(&pdev->dev); > > > > > > return 0; > > > > I would think the otg is a run_wake device, even though we have not > > marked it run_wake with a quirk (i guess no one checks that so > > far). So why do we need this check? > > > > From my point of view, the langwell_otg which belongs to pci driver > should check run_wake before pm_runtime_put_noidle. > Please refer to hcd-pci.c. [Jacob Pan] In that case, we should also add a pci quirk to mark it run_wake. _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
