> > --- linux-2.6.37.bak/arch/x86/kernel/cpu/cpufreq/sfi-cpufreq.c
> > 2011-06-07 17:03:02.677370904 +0800
> > +++ linux-2.6.37/arch/x86/kernel/cpu/cpufreq/sfi-cpufreq.c
> > 2011-06-09 13:24:16.238205000 +0800
> > @@ -364,7 +364,6 @@ static int sfi_cpufreq_cpu_init(struct c
> >     if (result)
> >             goto err_freqfree;
> >
> > -   sfi_cpufreq_driver.get = get_cur_freq_on_cpu;
> 
> if you don't provide a .get you also don't get the sysfs 
> files for it....
> that's a bit extreme...
> 
> 

I see.

Currently we can not get actually "hardware" CPU frequency.
For cpuinfo_cur_freq is used to show the "hardware" CPU frequency, I
suppose it can not report cached_freq directly.
And the .get function is optional (in include/linux/cpufreq.h, comment
of get: "should be defined, if possible").
In another hand, users still can get current frequency of the CPU as
determined by the governor and cpufreq core by scaling_cur_freq.
So that I recommand remove cpuinfo_cur_freq support to follow the
declaration of cpufreq.
If we can clarify how to get actually "hardware" CPU frequency, we can
add it back.

- Lee
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel

Reply via email to