Dear Arjan, Sorry, our patch confuses to you. The purpose of patch is not add runtime-pm function. Runtime-pm function is already implemented in open/close function in ektf2136 driver.
Its specifically for getting palm-rejection parameters from ektf2136 firmware, its a non shared IRQ and dedicate to ektf2136. Thanks. -----Original Message----- From: Arjan van de Ven [mailto:[email protected]] Sent: Thursday, June 23, 2011 12:14 PM To: 劉嘉駿 Cc: [email protected]; [email protected]; [email protected]; [email protected]; Mike T Hsu/WHQ/Wistron; Dirk Brandewie Subject: Re: [Meego-kernel] [PATCH] ektf2136_spi : Add palm-rejection function On 6/22/2011 7:18 PM, 劉嘉駿 wrote: > > Hi Arjan, > > uhhhh > > NO! > > disable_irq() is very very evil. > > you had a somewhat valid reason for it in your firmware recovery path... > > but not here. > > A: Because ektf2136_spi is not shared irq and this disable_irq() is > for to avoid disturbed regular ISR routine. > > Ektf2136 supports user to get/set palm-rejection parameters runtime. > Once user is going to get palm-rejection parameter and then > > we are simply disable_irq() for received data from touch device by > elan_touch_get_pr_cmd(), after parameter returned, we are enable_irq() > for > > normal process. > hmmmmmmmmm really really not convinced. Adding Dirk to the CC, our SPI driver specialist; maybe he can weigh in on this > also, this function is missing the get/put for the runtime PM, so you're > > talking to your chip while it is in power management mode... is that > valid? > > A: Power-mangement control was control in open() / close() function, > so there are no problem during get/put command running. > except that this is done on sysfs files, which do not go via the normal open/close path of the regular device node! _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
