On Thu, Mar 12, 2009 at 10:02 PM, Kai Willadsen <[email protected]> wrote: > In choose_vc(), there is this: > > + self.combobox_vcs.set_tooltip_text(tooltip_texts[len(vcs) == 1]) > > The gtk.Tooltip API is new in 2.12, so this needs to be guarded > against older versions. In a couple of other places in meld, there's a > simple check along the lines of: > > if gtk.pygtk_version >= (2, 12, 0): > x.set_tooltip_text(y) > > for this exact API, so that should go here too.
Done >> set-vcview-fileentry-hbox2-spacing-to-hig-stds.patch is the HIG >> compliance patch from Kai. (hope this is all of it, and didn't miss >> anything) > > I think Stephen was right here, and these spacings shouldn't both be > 6. I'd say either set the hbox2 spacing to 12, or the HistoryFileEntry > spacing to 3. I'd probably go with the second option, but I don't > actually mind. Done, HFE spacing to 3, hbox kept to 6. > Otherwise, looks like a really nice addition to me. Thanks for your reviews, they're very useful, and insightful... -- Vincent Legoll _______________________________________________ meld-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/meld-list
