On Fri, Apr 3, 2009 at 9:27 AM, Stephen Kennedy <[email protected]> wrote: > 2009/3/30 Vincent Legoll <[email protected]>: >> here is a first shot at replacing the hard-coded >> directory filter for VC metadata directories. >> >> I'd really appreciate comments about how to >> implement a better (complete ?) shell_escape() >> in misc.py. The current one is working for now >> but is not OK for a long term solution. > > Looks good. Maybe just punt for now and assert > on the unhandled cases? In this case it might be > better to keep the "incomplete" function local in > meldapp.py
I'm really not sure we want to put an unrelated function like that in meldapp.py, it is the complementary to shell_to_regex(), so I think it should be near, even if not completely implemented. I'll add the required assertions though -- Vincent Legoll _______________________________________________ meld-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/meld-list
