On 17 October 2011 22:39, Antoine <[email protected]> wrote: > Le 17/10/2011 13:23, Kai a écrit : >> More generally speaking, we definitely want some kind of dbus >> interface. Getting that code working is also relatively simple. >> However, any interface we add would risk becoming an ABI that we'd >> have to maintain, so it would be good to get it right. > > Hi, > > I've maintained Kacper Wysocki 's adapted patch and used it successfully > since v1.3.1-1 > Cf https://bugzilla.gnome.org/show_bug.cgi?id=616466 > > Please find attached successive patches: > meldapp.1.3.2-1_option--newtab.patch > meldapp.1.3.2-2_option--newtab.patch > meldapp.1.4.0-2_option--newtab.patch > meldapp.1.5.0_option--newtab.patch > meldapp.1.5.1-1_option--newtab.patch > meldapp.1.5.2-1_option--newtab.patch > > I also attach one I currently use at that time for switching to appropriate > workspace, but which rely on GNU/linux wmctrl tool: > meldapp.1.5.2-1_option--newtab+wmctrl.patch > > I can re-open a new bugzilla if you need me and I remain at your disposal > for any testing > thanks again for this great app ! > cheers > Antoine
Ah, thanks. I didn't know that anyone was keeping it up to date. From looking at the patch, there's still some work needed before it could actually be merged. For a start, it fails if dbus isn't available (yes, it looks like it tries to fail gracefully, but it doesn't; declaring DBusProvider requires dbus.service.Object, which breaks). Also, Stephen Kennedy's comments from bug 453670 are still relevant, and there's an optparse-related bugfix from Jeff Oliver in the same bug that isn't incorporated. The patch also demonstrates the issue of exposing a dbus ABI. The patch carries forward the auto-compare option in the dbus method, and I'm not sure that I'd want to include that at all. Looking at these issues is on my list, but as usual, it's a long list. cheers, Kai _______________________________________________ meld-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/meld-list
