On 20 March 2013 08:38, Piotr Piastucki <[email protected]> wrote:
> On 02/25/2013 08:48 PM, Kai Willadsen wrote:
>>
>> You're talking about your suggestion of doing an input split followed
>> by a double compare? In that case, yes, you should always get the sync
>> point included.
>>
>> I was talking about a different option entirely of simply forcing the
>> algorithm through that point. Since the result should be almost
>> identical (bar some heuristic speed-ups maybe?), I think doing
>> whatever is easiest is the best plan.
>>
>
> I am attaching a patch with SyncPointMyersSequenceMatcher class that
> does the split & merge as described before.
Awesome! I've attached your patch and my follow-ups to bug 362233:
https://bugzilla.gnome.org/show_bug.cgi?id=362233
Fundamentally, it works. However, the UI is not in a releasable state.
We'd need to add:
* Some indication as to the location of split points
* A way to clear/reset splits points (they're reset as is, but it's
not obvious, and you can't actually manually remove them)
* Some way of setting split points separately; just using the last
cursor position is really pretty awful
As a bonus, it would be nice to allow multiple split points. The
backend already supports this, but making the UI non-awful is going to
be complicated. It would also be good to allow moving split points,
but I really think that's a nice-to-have.
> There are also some unit tests included (at last). I have no idea what
> the UI should look like hence I did not even try to implement anything
> but the 'backend' stuff.
Tests?! I don't even know what to say.
...other than: oh yeah, some more of those would be nice...
cheers,
Kai
_______________________________________________
meld-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/meld-list
