On 20 October 2015 at 08:01, David Rabel <[email protected]> wrote:
> Hi Kai,
>
> thanks for your Email.
>
>
> On 18.10.2015 22:16, Kai Willadsen wrote:
>> ...
>> It's worth mentioning two PEP8 caveats. Firstly, PEP8 allows backslash
>> continuations for long lines, but we don't use them (by which I
>> mean... we don't use them *any more*). Secondly, PEP8 allows aligned
>> hanging indents for continued lines, but I would strongly discourage
>> this.
>> ...
>
> When you say, aligned hanging indents....
>
> Do you mean only(
> like,
> this)
>
> or (also, like,
> this)
>
> ?
>
> ;-)
Fair enough! I mean that the first of those two is good, the second is
discouraged.Although the first should just be:
something_long(
like, this, for, example)
rather than wrapping each arg on a newline, IMO. Having a new line for
each arg makes sense sometimes... but isn't really here nor there for
PEP8 purposes.
> I'll just start with filediff and dirdiff and have a look if there's
> some files which are nearly PEP8.
Oh sorry if I wasn't clear. I would suggest *not* trying to PEP8
filediff or dirdiff. I think fixes to those are likely to be too
disruptive in terms of git annotate, etc. for me to be happy applying.
> Again my question:
>
>>> Do I have to file a bug on bugzilla for this? Or has
>>> someone else to do this?
You're welcome to either file a bug for this yourself, or attach
patches on the list. Either way works for me.
cheers,
Kai
_______________________________________________
meld-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/meld-list
