On Mar 18, 6:41 pm, Toru Maesaka <[email protected]> wrote: > Yo, > > Just reviewed through the tree and it looks fine to me. The only thing > that caught my eye is this in memcached.c (line 2626): > > + if (handle_cas) { > + req_cas_id = strtoull(tokens[5].value, NULL, 10); > > This should be using the new safe_strtoull().
How does this look? http://github.com/dustin/memcached/commit/d0fee94ed75e304c66ba17fbd47b44aab6a33513 > The new internal_test and the build test passes both on Mac OS X and > Ubuntu 8.04 64bit. It's really nice how we have a dedicated file for > utility functions now, things like this are always handy ;) I've been pretty good about putting everything through my builders (8 variations -- need more!). Every extra check is great, though. :)
