Shouldn't be ... the allocation is the same, but no new stats have been added into stats slabs under 1.2.8, so the allocation is still "correct".
-Dormando On Mon, 13 Apr 2009, Evan Weaver wrote: > > Is this bug present in 1.2.8? > > Evan > > On Thu, Apr 2, 2009 at 12:56 PM, Dustin <dsalli...@gmail.com> wrote: > > > > > > On Apr 2, 1:03 am, Toru Maesaka <tmaes...@gmail.com> wrote: > > > >> So we've been testing memcached-1.3.2 beta at mixi.jp for > >> a week and we found an issue in the stats code. > >> > >> The problem is that the server segfaults if we issue the > >> "stats slabs" command to a daemon that has lots of slab > >> classes (approximately 40). > >> > >> The cause is simply not allocating enough memory for the > >> result buffer in do_slabs_stats() in slabs.c: > >> > >> char *buf = (char *)malloc(power_largest * 200 + 100); > > > > That's a good find, though really kind of unsurprising since there > > were a lot of places where we were sort of guessing about how much > > memory we needed to build out stats. > > > > Trond did some awesome work on making *all* stat buffers dynamic. > > There was one small bug in it that we found early, but this should > > categorically clean up these problems. > > > > > > > > -- > Evan Weaver >
