Re: Issue 115 in memcached: item_size_ok doesn't account for CAS

[memcached]

Comment #6 on issue 115 by trond.no...@gmail.com: item_size_ok doesn't  
account for CAS
http://code.google.com/p/memcached/issues/detail?id=115
The only "problem" caused by this bug is that the "wrong" error message is  
returned back to the client:

First we call:
    it = item_alloc(key, nkey, flags, realtime(exptime), vlen);

item_alloc accounts for CAS if it's used.

Then we check for the result, and if it failed we're going to try to check  
why:
    if (it == 0) {
        if (! item_size_ok(nkey, flags, vlen))
            out_string(c, "SERVER_ERROR object too large for cache");
        else
            out_string(c, "SERVER_ERROR out of memory storing object");

I wouldn't call this a hight priority bug, but at the same time it isn't  
hard to fix ...