A few things off the top: - That intel copyright notice is absolutely brutal. I can't accept code with that thing in there. Memcached is BSD licensed, and code must be accepted under those same terms (a copy of the license is included in the source code).
- Not sure why your patch *removes* the shutdown command. Was that an accident? - You don't need to put your name around any modifications. That's what git history is for. - Variable names are inconsistent with the surrounding code. camelCased instead of under_scored. - Spacing is tabbed? Looks huge. - Not really sure how I feel about C functions in header files. I'm sure that's a crazy old argument but it's inconsistent with the rest of the codebase. thanks! -Dormando On Tue, 12 Feb 2013, zfad...@gmail.com wrote: > Added thread affinity capability. The code is here: > https://github.com/zfadika/memcached > > On Thursday, February 7, 2013 2:57:49 PM UTC-5, Dormando wrote: > what? > > On Thu, 7 Feb 2013, zfa...@gmail.com wrote: > > > I thought you were sleeping?� :) > > � > > > > On Thursday, February 7, 2013 11:09:01 AM UTC-8, Dormando wrote: > > You fork, then push to your own repo that you just forked. > > > > If what you're doing worked, we'd be in one crazy chaotic world. > > > > On Thu, 7 Feb 2013, zfa...@gmail.com wrote: > > > > > I tried: > > > � > > > I am getting: > > > � > > > Pushing to g...@github.com:memcached/memcached.git > > > ERROR: Permission to memcached/memcached.git denied to > zfadika. > > > fatal: Could not read from remote repository. > > > Please make sure you have the correct access rights > > > and the repository exists. > > > � > > > > > > On Wednesday, February 6, 2013 10:51:12 PM UTC-8, Toru > Maesaka wrote: > > > � � � You don't have to see anyone to present your work. > > > > > > Good start would be to fork memcached on GitHub, create your > own branch and send a pull request to upstream with the patch & description > of what you're trying to accomplish. > > > > > > https://github.com/memcached/memcached > > > > > > More info can be found here: > > > https://code.google.com/p/memcached/wiki/DevelopmentRepos > > > > > > > > > On Thu, Feb 7, 2013 at 3:44 PM, <zfa...@gmail.com> wrote: > > > � � � Hello all, I work for Intel, and I added some > performance code for better performance on Intel Architecture in 1.4.15. > > > Who do I see to push it up to a branch, or submit a patch for > it????? > > > > > > -- > > > � > > > --- > > > You received this message because you are subscribed to the > Google Groups "memcached" group. > > > To unsubscribe from this group and stop receiving emails from > it, send an email to memcached+...@googlegroups.com. > > > For more options, visit > https://groups.google.com/groups/opt_out. > > > � > > > � > > > > > > > > > -- > > > � > > > --- > > > You received this message because you are subscribed to the > Google Groups "memcached" group. > > > To unsubscribe from this group and stop receiving emails from > it, send an email to memcached+...@googlegroups.com. > > > For more options, visit > https://groups.google.com/groups/opt_out. > > > � > > > � > > > > > > > > > > -- > > � > > --- > > You received this message because you are subscribed to the Google > Groups "memcached" group. > > To unsubscribe from this group and stop receiving emails from it, > send an email to memcached+...@googlegroups.com. > > For more options, visit https://groups.google.com/groups/opt_out. > > � > > � > > > > > > -- > > --- > You received this message because you are subscribed to the Google Groups > "memcached" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to memcached+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- --- You received this message because you are subscribed to the Google Groups "memcached" group. To unsubscribe from this group and stop receiving emails from it, send an email to memcached+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
