Thanks for all the patches related to Python 3. I think we should better don't touch pywatchman because they have already worked on it and will be sending a pull request to Mercurial soon. https://github.com/facebook/watchman/pull/247
On Sun, Oct 9, 2016 at 3:55 PM, Mateusz Kwapich <mitran...@fb.com> wrote: > # HG changeset patch > # User Mateusz Kwapich <mitran...@fb.com> > # Date 1476021239 25200 > # Sun Oct 09 06:53:59 2016 -0700 > # Node ID dd705da68bdc7e52ca7a06e92e0fb6e74af6647b > # Parent 9be0fc83663857b8843a781b6418a42fa0b15c65 > py3: slots should be unicode strings (pywatchman) > > like in mercurial/util.py:566 > > diff --git a/hgext/fsmonitor/pywatchman/pybser.py > b/hgext/fsmonitor/pywatchman/pybser.py > --- a/hgext/fsmonitor/pywatchman/pybser.py > +++ b/hgext/fsmonitor/pywatchman/pybser.py > @@ -236,7 +236,7 @@ def _bunser_array(buf, pos, mutable=True > # It provides by getattr accessors and getitem for both index > # and name. > class _BunserDict(object): > - __slots__ = ('_keys', '_values') > + __slots__ = (u'_keys', u'_values') > > def __init__(self, keys, values): > self._keys = keys > _______________________________________________ > Mercurial-devel mailing list > Mercurial-devel@mercurial-scm.org > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel