On Sun, Oct 9, 2016 at 4:35 PM, Martijn Pieters <m...@zopatista.com> wrote: > On 9 October 2016 at 16:32, Kevin Bullock <kbullock+mercur...@ringworld.org> > wrote: >> >> > On Oct 9, 2016, at 16:16, Augie Fackler <r...@durin42.com> wrote: >> > >> > # HG changeset patch >> > # User Augie Fackler <au...@google.com> >> > # Date 1476019688 14400 >> > # Sun Oct 09 09:28:08 2016 -0400 >> > # Node ID e6a69e778cb02cada23352df512b8580026640d9 >> > # Parent e89f400277d564c4a576ad8e4a6003a201993639 >> > extensions: fix extension module hunting on Python 3 >> > >> > importlib is a firm believer that paths are really strings, not >> > bytes. Fortunately we have os.fsdecode to help us with that. >> >> As I just discovered looking into our current py2.6 breakage on buildbot, >> importlib doesn't exist at all until 2.7. > > > Ick. Urg. Having to backport importlib to 2.6 may hurt. > >> >> Also a question on this series: no test changes in >> test-check-py3-compat.t?
Yeah we are now fixing issues by running commands like hg version, debuginstall or trying to make local on Python 3. > > > These are all found by running hg version; Pulkit's patch to add commands to > test-check-py3-compat.t should remedy this issue. Apart from adding a #if py3exe, that patch needs some treatment related to paths, will copy the way we show the message in test-check-py3-compat.t, will need to write a script in contrib, will do that shortly. >> >> pacem in terris / мир / शान्ति / سَلاَم / 平和 >> Kevin R. Bullock >> >> _______________________________________________ >> Mercurial-devel mailing list >> Mercurial-devel@mercurial-scm.org >> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel > > > > > -- > Martijn Pieters > > _______________________________________________ > Mercurial-devel mailing list > Mercurial-devel@mercurial-scm.org > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel > _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
