On 10/11/2016 06:25 PM, Stanislau Hlebik wrote:
# HG changeset patch # User Stanislau Hlebik <st...@fb.com> # Date 1476195835 25200 # Tue Oct 11 07:23:55 2016 -0700 # Node ID 55e997127023d7208488c593adb933a1bfb23312 # Parent b85fa6bf298be07804a74d8fdec0d19fdbc6d740 exchange: add `_getbookmarks()` function This function will be used to generate bookmarks bundle2 part. It is a separate function in order to make it easy to overwrite it in extensions. Passing `kwargs` to the function makes it easy to add new parameters in extensions. diff --git a/mercurial/exchange.py b/mercurial/exchange.py --- a/mercurial/exchange.py +++ b/mercurial/exchange.py @@ -1672,6 +1672,17 @@ if chunks: bundler.newpart('hgtagsfnodes', data=''.join(chunks)) +def _getbookmarks(repo, **kwargs): + """Returns list of bookmarks. + + This function is primarily used to generate `bookmarks` bundle2 part. + It is a separate function in order to make it easy to wrap it + in extensions. Passing `kwargs` to the function makes it easy to + add new parameters in extensions. + """ + + return repo.listkeys(namespace='bookmarks')
I find it quite suspicious that we need to get through listkeys to get the list of bookmarks. Instead I would expect us to have a function ready to use in the bookmark module itself. Can you look into this ?
Cheers, -- Pierre-Yves David _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel