On 01/04/2017 08:09 PM, Martin von Zweigbergk via Mercurial-devel wrote:
On Wed, Jan 4, 2017 at 11:06 AM, Pierre-Yves David
<pierre-yves.da...@ens-lyon.org> wrote:


On 01/04/2017 07:52 PM, Martin von Zweigbergk via Mercurial-devel wrote:

# HG changeset patch
# User Martin von Zweigbergk <martinv...@google.com>
# Date 1483554904 28800
#      Wed Jan 04 10:35:04 2017 -0800
# Node ID c9c5864ddd54b240692a2712d59227c9d4ca2f99
# Parent  acf0037a9a5bb14603bb50c57822d4ab5896e5b5
repair: combine two loops over changelog revisions

This just saves a few lines.


Beware that cl.revs(start) might be different from
xrange(start, len(cl)) if filtering come into play.

Good point.


I would vaguely assume that strip is enforcing it run on an unfiltered
changelog, but can you double check that?

Yep, about 20 lines up, you'll find these two lines:

    repo = repo.unfiltered()
[...]
    cl = repo.changelog

Thanks for double checking, these are pushed.

Cheers,

--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to