On 01/09/2017 05:27 AM, timeless wrote:
Gregory Szorc wrote:
Your reasoning about users wanting extra context to help them debug is sound.
But I'm surprised nobody mentioned that the "error.Abort" exception takes an
optional keyword "hint" argument that prints an extra message to provide that 
context.
When we know why an abort occurred and/or what actions can be taken to prevent 
it,
the "hint" message should provide that context.

+1

Actually, I did mention we should augment 'checkunfinished()' and 'bailifchanged()' to be able to provide more context ;-) So +1 for improving these too (but as mentioned in my initial reply, that's a scope bloat so I too the debug version for now).

(third paragraph of
https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-January/092041.html )

Cheers,

--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to