At Fri, 3 Feb 2017 20:26:04 -0800, Rodrigo Damazio wrote: > > [1 <multipart/alternative (7bit)>] > [1.1 <text/plain; UTF-8 (7bit)>] > Finally working on this again. > On point which I discussed with Martin offline - which feels more intuitive > as a prefix, "root" or "abs"? (so, "rootfilesin" or "absfilesin"?) We think > it's "abs", but wanted to make sure that's OK with others.
In FileNamePatternsPlan page, I choose "root" as a name of point, to which patterns are relative ("root", "cwd", and "any"). I'm OK with "abs", if other thinks that it is more intuitive for "relative to the root". BTW, are "cwd" and "any" prefixes are OK with "abs" ? > Thanks > > > On Sun, Jan 29, 2017 at 3:15 AM, FUJIWARA Katsunori <fo...@lares.dti.ne.jp> > wrote: > > > > > At Fri, 27 Jan 2017 15:14:38 -0800, > > Rodrigo Damazio wrote: > > > > > > [1 <multipart/alternative (7bit)>] > > > [1.1 <text/plain; UTF-8 (7bit)>] > > > On Fri, Jan 27, 2017 at 1:03 AM, FUJIWARA Katsunori < > > fo...@lares.dti.ne.jp> > > > wrote: > > > > > > > > > > > At Thu, 26 Jan 2017 17:27:17 -0800, > > > > Rodrigo Damazio wrote: > > > > > > > > > > [1 <multipart/alternative (7bit)>] > > > > > [1.1 <text/plain; UTF-8 (7bit)>] > > > > > All sounds very reasonable, and "filesin:" or "rootfilesin:" LGTM. > > > > > > > > Is it OK for your solution that "rootfilesin:FOO" doesn't match > > > > against "file FOO", even though your patch posted in this thread made > > > > "files:FOO" do so ? or, is combining "rootfile:" and "rootfilesin" > > > > acceptable for your solution ? > > > > > > > > > > Yes, not matching files is fine, and actually the easiest to implement > > (the > > > regex is simpler and our custom server doesn't support files anyway). > > > For that, rootfilesin:foo/bar can produce regex ^foo/bar/[^/]+$ or > > similar > > > which would not match a file called bar. visitdir would have to be > > updated > > > accordingly, of course, but that shouldn't be too hard (and i can take > > the > > > opportunity to add some comments to the code). > > > > > > If that looks good to you, let me know and I'll send an updated patch. > > > > Sure, LGTM > > > > -- > > ---------------------------------------------------------------------- > > [FUJIWARA Katsunori] fo...@lares.dti.ne.jp > > > [1.2 <text/html; UTF-8 (quoted-printable)>] > > [2 S/MIME Cryptographic Signature <application/pkcs7-signature (base64)>] > -- ---------------------------------------------------------------------- [FUJIWARA Katsunori] fo...@lares.dti.ne.jp _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel