On 03/22/2017 11:04 AM, Ryan McElroy wrote:
On 3/21/17 10:42 PM, Pierre-Yves David wrote:
# HG changeset patch
# User Pierre-Yves David <pierre-yves.da...@ens-lyon.org>
# Date 1490135413 -3600
#      Tue Mar 21 23:30:13 2017 +0100
# Node ID 787354f0d60eccda66ba0de4db8e6e47897acc7c
# Parent  66c3ae6d886cae0e3a3cff6a0058e2d2a866fd9d
# EXP-Topic checkheads
# Available At
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_repo_users_marmoute_mercurial_&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=Jw8rundaE7TbmqBYd1txIQ&m=X1PCqIb1foE38fk_XWYf-aaAwDmJ4P0klZVtI7TGEWk&s=BDwmpGmjYfrQ5_BZQ-19-vlGJwbvEH2-rewqp3-9cCI&e=

#              hg pull
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_repo_users_marmoute_mercurial_&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=Jw8rundaE7TbmqBYd1txIQ&m=X1PCqIb1foE38fk_XWYf-aaAwDmJ4P0klZVtI7TGEWk&s=BDwmpGmjYfrQ5_BZQ-19-vlGJwbvEH2-rewqp3-9cCI&e=
-r 787354f0d60e
checkheads: extract obsolete post processing in its own function

The checkheads function is long and complex, extract that logic in a
subfunction
is win in itself.

I agree, this looks good to me.

Actually, we should probably pass a the pushoperation instead of the repository. That logic will needs to poke at the remote repository (eg: Sean told me about a bug reported to bitbucket were this logic kicks in even if obsolescence markers are not going to be exchanged.

V2 incoming.

Cheers,

--
Pierre-Yves David
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to