Jun, et al: The recent patches around hardlink detection are great! However, there are still some failures executing tests in certain Docker configurations, such as when using the overlay2 storage driver (overlayfs).
--- /mnt/hg/tests/test-hardlinks.t +++ /mnt/hg/tests/test-hardlinks.t.err @@ -58,14 +58,14 @@ Create hardlinked clone r2: $ hg clone -U --debug r1 r2 --config progress.debug=true - linking: 1 - linking: 2 - linking: 3 - linking: 4 - linking: 5 - linking: 6 - linking: 7 - linked 7 files + copying: 1 + copying: 2 + copying: 3 + copying: 4 + copying: 5 + copying: 6 + copying: 7 + copied 7 files Create non-hardlinked clone r3: "#require hardlink" is returning true. But hardlinks don't really work on overlayfs it appears. I see there is now a test-hardlinks-whitelisted.t, which is a copy of test-hardlinks.t but uses the new filesystem detection code for whitelisting hardlinks. test-hardlinks-whitelisted.t passes under Docker on overlayfs, which is terrific! But it begs the question: what's our strategy for making tests pass when run under "faulty" filesystems? I ask because `make docker-*` targets run the test harness and test failures abort that process. So it would be nice to not have test failures under Docker. (FWIW there are some permissions related failures running tests under Docker as well. I encourage others to run `make docker-ubuntu-xenial` and other docker-* targets to poke at things.)
_______________________________________________ Mercurial-devel mailing list [email protected] https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
