On Sun, 21 May 2017 23:16:04 -0700, Martin von Zweigbergk via Mercurial-devel wrote: > # HG changeset patch > # User Martin von Zweigbergk <martinv...@google.com> > # Date 1495148746 25200 > # Thu May 18 16:05:46 2017 -0700 > # Node ID fcf2e822e20b4c25e4525057a0fdf8221e48b0ec > # Parent 6bf950ac0b443b409e744bb0cff6b340197dbdd2 > match: don't print explicitly listed files with wrong case (BC) > > On case-insensitive file systems, if file A exists and you try to > remove it (or add, etc.) by specifying a different case, you will see > something like this: > > $ hg rm a > removing file A > > I honestly found this surprising because it seems to me like it was > explicitly listed by the user. Still, there is a comment in the code > describing it, so it is very clearly intentional. The code was added > in baa11dde8c0e (match: add a subclass for dirstate normalizing of the > matched patterns, 2015-04-12). > > I'm going to do a lot of refactoring to matchers and the feature > mentioned above is going to get in my way. I'm therefore removing it > for the time being and we can hopefully add it back when I'm done. > > diff --git a/mercurial/match.py b/mercurial/match.py > --- a/mercurial/match.py > +++ b/mercurial/match.py > @@ -450,19 +450,11 @@ > init(root, cwd, patterns, include, exclude, default, auditor=auditor, > ctx=ctx, listsubrepos=listsubrepos, badfn=badfn) > > - # m.exact(file) must be based off of the actual user input, otherwise > - # inexact case matches are treated as exact, and not noted without > -v. > - if self._files: > - roots, dirs = _rootsanddirs(self._kp) > - self._fileset = set(roots) > - self._fileset.update(dirs)
Dropping inexact message seems fine. Matt, please let us know if you remember a pitfall other than the status message. icasefs seems really picky. _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
