Martin von Zweigbergk via Mercurial-devel <mercurial-devel@mercurial-scm.org> writes:
> # HG changeset patch
> # User Martin von Zweigbergk <martinv...@google.com>
> # Date 1498892339 25200
> # Fri Jun 30 23:58:59 2017 -0700
> # Node ID d4e1f3ac5a45534203caafe5bd7bd66f3b54c4e0
> # Parent 748b0ea7aa3b88ef8ccdd236339d9a2daba18f54
> changegroup: don't fail on empty changegroup (API)
>
> I don't know why applying an empty changegroup should be an error. It
> seems harmless. I suspect the check was there to find code that
> creates empty changegroups just because that would be wasteful. Let's
> use develwarn() for that instead, so we catch any such cases that run
> with our test runner, but we still allow others to generate empty
> changegroups if they want to.
>
> We have run into this check at Google once or twice and had to work
> around it, but I'm changing this not so much because of that, but
> because it seems like it shouldn't be an error.
>
> I also changed the message slightly to be more modern ("changelog
> group" -> "changegroup") and more generic ("received" -> "applied").
Makes sense to me. Queued!
signature.asc
Description: PGP signature
_______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
