On Thu, Jul 6, 2017 at 6:18 PM, Gregory Szorc <gregory.sz...@gmail.com> wrote: > # HG changeset patch > # User Gregory Szorc <gregory.sz...@gmail.com> > # Date 1499379254 25200 > # Thu Jul 06 15:14:14 2017 -0700 > # Node ID fe47ebda0b384aa1d3002c6db3c4bace60472337 > # Parent 1c1a25d842854cbb2a7516136f7bcaab0d9f4539 > sparse: move post commit actions into core > > Instead of wrapping committablectx.markcommitted(), we inline > the call into localrepository.commit(), which is the only place > we call markcommitted(). > > The APIs and distribution of duties between > localrepository.commit() and committablecontext.markcommitted() > are unclear to me. As is the proper order for certain operations > to be performed. There is room to improve this code.
4fb92f14a97a (commit: factor out post-commit cleanup into workingctx, 2013-02-08) says that markcommitted() was created to prepare for in-memory merge. Given that, it seems more appropriate to leave the call to sparse.aftercommit() at the end of committablectx.markcommitted(), no? (I say "leave" because that's where it was essentially called from in the wrapper.) I'll queue 1-9 and let you think about this one a bit. Thanks! _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
