martinvonz added inline comments.

INLINE COMMENTS

> lothiraldan wrote in util.py:599
> The initial check was slighty more precise (if tr is not None), any specific 
> reason for the change?

We generally prefer "not X" over "is not None" when they're functionally 
equivalent (and I do think they are here).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D66

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: martinvonz, #hg-reviewers
Cc: lothiraldan, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to