durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
A style nit, generally +1 and if you get the style nits handled we should be
good to go.
INLINE COMMENTS
> releasenotes.py:266
> + else:
> + ui.write(_("Invalid admonition \'%s\' present in changeset
> %s\
> +\n") % (admonition.group(1), ctx.hex()[:12]))
nit: in a "-quoted string, you can omit \ on '
not a nit: use
("foo"
"bar")
instead of \ to wrap a multi-line string literal (the concatenation is implicit
at module load time).
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D368
To: rishabhmadan96, #hg-reviewers, durin42
Cc: durin42, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
