indygreg added inline comments. INLINE COMMENTS
> mbthomas wrote in test-revlog-mmapindex.t:12-13 > For (1) There's no `ui` object available in the `revlog.revlog` constructor. > Is there a way to get one? > For (2), the rest of the test suite will be loading the revlog without mmap, > so I didn't think it necessary to test it again here. I'd do it with inline Python. Something like: >>> from mercurial import hg, ui as uimod >>> myui = uimod.ui.load() >>> repo = hg.repository(myui, path='.') >>> >>> 1. Test repo.changelog here. Also, excessive `hg` commands makes tests slow. Unfortunately, doing this in Python is probably a bit of work :/ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D477 To: mbthomas, #fbhgext, indygreg, #hg-reviewers, durin42 Cc: quark, durin42, simonfar, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
