quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY `_bbvfs` is redundant because it could be calcualted from `_bbrepo`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D651 AFFECTED FILES hgext/blackbox.py CHANGE DETAILS diff --git a/hgext/blackbox.py b/hgext/blackbox.py --- a/hgext/blackbox.py +++ b/hgext/blackbox.py @@ -82,19 +82,23 @@ else: self._bbinlog = False self._bbrepo = getattr(src, '_bbrepo', None) - self._bbvfs = getattr(src, '_bbvfs', None) def _partialinit(self): - if util.safehasattr(self, '_bbvfs'): + if self._bbvfs: return self._bbinlog = False self._bbrepo = None - self._bbvfs = None def copy(self): self._partialinit() return self.__class__(self) + @property + def _bbvfs(self): + repo = getattr(self, '_bbrepo', None) + if repo: + return repo.vfs + @util.propertycache def track(self): return self.configlist('blackbox', 'track', ['*']) @@ -194,7 +198,6 @@ def setrepo(self, repo): self._bbinlog = False self._bbrepo = repo - self._bbvfs = repo.vfs ui.__class__ = blackboxui uimod.ui = blackboxui To: quark, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel