yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
Queued, thanks.
> I don't think we can just swap c1 and c2 because what we're calculating
> is the copy from c1 to c2,
For the record, this statement appears to be wrong, sorry. Perhaps the idea
of swapping c1 and c2 would be valid, though there was a bug. However, I
still think the new code is better because the untested part is simpler and
less error-prone.
INLINE COMMENTS
> copies.py:637
> + baserev = base.rev()
> + if not repo.revs('%d::%d', baserev, c2rev):
> + # If base is not in c2 branch, we switch to fullcopytracing
Folded these variables which are used only once.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D623
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
