durham accepted this revision. durham added a comment.
I think the name could be better, but that can be bikeshed. Stamping my approval for the concept and pattern. INLINE COMMENTS > registrar.py:148 > > +class cmdtype(object): > + """ enum for the type of command which will tell whether the command is `cmdtype` might be overly vague, since I could imagine a number of classifications it could mean. Maybe "cmdwritetype"? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D696 To: pulkit, #hg-reviewers, durham Cc: durham, indygreg, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
