martinvonz added a comment.
In https://phab.mercurial-scm.org/D542#13779, @quark wrote: > In https://phab.mercurial-scm.org/D542#13621, @martinvonz wrote: > > > I've found the information from the effectflag that's used in "hg obslog" useful. As you've probably seen, I've also sent a patch for recording the operation by default (implemented by Durham once upon a time, I think). I don't mind seeing turning both of these features on by default and we can let time tell which of them users find most useful and keep only that, or we can decide to keep both. I was about to queue this series, but it uses the old [evolution] config section, so at least that will have to change before I can accept it. > > > According to https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-May/098173.html, I think you prefer not storing the information in obsstore. Have you changed mind or do you think it could be improved in the future? I have not changed my mind. I think the *feature* is useful, so I'm happy to get this in. I don't buy the argument about needing to know the effect in changesets that are not known locally, so I think I'd be fine with changing this code in the future to calculate the effectflags on the fly. The effectflags are currently only used in "hg obslog", which is used much less frequently than "hg log", so I think we'd even be fine with not caching the values (so they're always calculated on the fly). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D542 To: lothiraldan, #hg-reviewers, quark Cc: martinvonz, quark, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
