yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  So the messages may be rolled back, which seems to be against the original
  intent, "take messages out of the function so that extensions can add 
entries."
  
  Since extensions have to wrap the _getmessages() function, the messages
  table isn't necessary, so we don't need the callback mechanism, too.
  Alternatively, the messages table could keep the raw (untranslated) messages,
  to which gettext() will be applied later.
  
    messages = {
        ...
            'discard': "discard change %d/%d to '%s'?",
    }
    i18nblahblah = messages.... # tell hggettext to extract strings
    
    ....
        i18n.gettext(messages[k][op])

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D959

To: quark, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to