ryanmce requested changes to this revision.
ryanmce added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> commands.py:800
> + if firsttime:
> + raise error.Abort(_('not in a bisect'))
> + cmdutil.checkunfinished(repo)
Histedit does this:
abort: no histedit in progress
That wording sounds more natural to me, so I'd suggest something similar here,
like:
abort: no bisect in progress
> commands.py:804
> + if not state['original']:
> + ui.warn(_('warning: unknown original changeset\n'))
> + else:
I think we can be more clear here. It's not that the original is an unknown
node (which is how I parse this wording), but that that state file didn't have
one, so perhaps "warning: not updating since bisect state did not include
original changeset" would be more clear (though it's a bit wordy).
> dlax wrote in commands.py:809
> This "bisect aborted" message is not very useful (especially at "warning"
> level): either the command fails with a message or it succeeds silently. Also
> maybe it'd be more useful to display the new working directory parent.
I agree. This can be a status or even an info. +1 on the idea of mentioning the
parent.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1044
To: quark, #hg-reviewers, ryanmce
Cc: ryanmce, dlax, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
