# HG changeset patch # User Boris Feld <boris.f...@octobus.net> # Date 1508248540 -7200 # Tue Oct 17 15:55:40 2017 +0200 # Node ID cfaaca09ba21da03f44a253348bc5de968928da3 # Parent 018fdb537668a81bd1f949ae6fe987a58b281ebf # EXP-Topic b2.bookmarks # Available At https://bitbucket.org/octobus/mercurial-devel/ # hg pull https://bitbucket.org/octobus/mercurial-devel/ -r cfaaca09ba21 exchange: drop unused '_getbookmarks' function
The function was introduced in 8491845a75b2 in mid-November 2016 but is never used anywhere in core. Binary support for bookmarks has now landed in core and the getbundle API makes it easy to override it. So we just remove the dead (unborn?) code. diff --git a/mercurial/exchange.py b/mercurial/exchange.py --- a/mercurial/exchange.py +++ b/mercurial/exchange.py @@ -1875,17 +1875,6 @@ def _getbundletagsfnodes(bundler, repo, outgoing = _computeoutgoing(repo, heads, common) bundle2.addparttagsfnodescache(repo, bundler, outgoing) -def _getbookmarks(repo, **kwargs): - """Returns bookmark to node mapping. - - This function is primarily used to generate `bookmarks` bundle2 part. - It is a separate function in order to make it easy to wrap it - in extensions. Passing `kwargs` to the function makes it easy to - add new parameters in extensions. - """ - - return dict(bookmod.listbinbookmarks(repo)) - def check_heads(repo, their_heads, context): """check if the heads of a repo have been modified _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel