quark accepted this revision.
quark added inline comments.

INLINE COMMENTS

> repoview.py:236-238
> +    def addvisibilityexceptions(self, exceptions):
> +        """adds hidden revs which should be visible to set of exceptions"""
> +        self._visibilityexceptions.update(exceptions)

Maybe rename `exceptions` to `revs` so people can know its type from the 
signature.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1285

To: pulkit, #hg-reviewers, quark
Cc: quark, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to