pulkit requested changes to this revision. pulkit added a comment. This revision now requires changes to proceed.
Apart from the comments, this patch looks good to me. INLINE COMMENTS > context.py:458 > > +def _getobsoletereason(ctx, unfilteredrepo): > + successors = obsutil.successorssets(unfilteredrepo, ctx.node()) nit: I think in such cases we pass repo as first argument. Also, I don't think this is a good place for this function, maybe move this to `obsutil.py` too. > obsutil.py:755 > +def _getobsfate(successorssets): > + """ Compute a changeset obsolescence fate based on his successorssets. > + Successors can be the tipmost ones or the immediate ones. This function s/his/it's > obsutil.py:759 > + be used by internal functions only. > + Returns one fate in the following list: > + - pruned s/in the following list/ from the following values > test-obshistory.t:287 > + $ hg update de7290d8b885 > + abort: hidden revision 'de7290d8b885' was rewritten as: 337fec4d2edc, > f257fde29c7a and 2 more! > + (use --hidden to access hidden revisions) We should follow the graph description here too i.e. saying `split as x,y,z`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1591 To: lothiraldan, #hg-reviewers, durin42, pulkit Cc: pulkit, durin42, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel