durin42 accepted this revision. durin42 added inline comments. INLINE COMMENTS
> dlax wrote in rebase.py:667 > Why would that be nice? Do you foresee any problem? > It just makes the code harder to follow, IMHO. > > Besides, now the `rebase()` no longer has a docstring, meaning that help is > broken. It's just a style thing. I find avoiding recursion to generally be clearer. @phillco dlax is right, the docstring needs fixed here (I'm surprised tests passed...) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1249 To: phillco, #hg-reviewers, durin42, dlax Cc: dlax, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
