yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> commandserver.py:454
> +            util.osutil.unblocksignal(signal.SIGCHLD)
> +        except (OSError, AttributeError):
> +            pass

My two cents, add alias `util.unblocksignal()`, and probably better not 
ignoring OSError.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1737

To: quark, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[email protected]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to