durham added inline comments.

INLINE COMMENTS

> rebase.py:812
> +        elif (ui.config('experimental', 'mergedriver') and
> +              ui.configbool('rebase', 
> 'experimental.inmemory.nomergedriver')):
> +            whynotimm = 'mergedriver enabled'

I think we probably want IMM disabled by default if merge drivers are 
specified.  If the merge-driver does IO during the preprocess step, it could 
cause problems in an IMM situation. So I don't think we can enable IMM by 
default in the merge-driver case until merge-driver enforces (or at least 
documents) that there should be no IO during preprocess.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1814

To: phillco, #hg-reviewers
Cc: durham, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[email protected]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to