durin42 added a comment.
In https://phab.mercurial-scm.org/D2048#34978, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D2048#34743, @durin42 wrote: > > > Can we do all of https://phab.mercurial-scm.org/D2048::https://phab.mercurial-scm.org/D2056 as a single change? What you've done means we have no useful blame information on everything done in https://phab.mercurial-scm.org/D2049::D0256... > > > Moving function one by one proved very useful in the past when refactoring like this triggered subtle bugs in core or extension. Having each move on its changeset make it easier to bisect the part that breaks other and save a great amount of time when that happens. Life's tough. I care more about the blame history on this code. (Other reviewers are welcome to overrule me, but I don't find this argument even slightly convincing.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2048 To: lothiraldan, #hg-reviewers, durin42 Cc: durin42, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
