martinvonz added a comment.
LGTM. Last time I was going to remove it, I left it in because Durham felt that it was useful for forcing him to not specialize the manifest API too much for how v1 works. I believe he's pretty much done with that now, so that should no longer be a reason to keep this around. Thanks for cleaning up. INLINE COMMENTS > manifest.py:537 > + def text(self): > + # use (probably) native version for v1 > + return self._lm.text() delete "for v1"? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2393 To: durin42, #hg-reviewers Cc: martinvonz, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel