pulkit added inline comments. INLINE COMMENTS
> state.py:84 > + if not isinstance(ret, dict): > + raise Exception("cbor parsed it wrong") > + return ret I am not confident about this part. Like to have some suggestions here. > state.py:86 > + return ret > + except: # cbor raises an Exception > + with self._repo.vfs(self.fname, 'rb') as fp: Should I change thirdparty/cbor/ to raise specific errors? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2593 To: pulkit, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel