quark added inline comments.

INLINE COMMENTS

> indygreg wrote in bdiff.c:239
> Calling `PyList_Append()` in tight loops can be a bit slow. It is faster to 
> allocate an array of `PyObject` and then allocate a `PyList` of final size 
> and call `PyList_SET_ITEM` to populate it. But we can optimize this later: 
> this is definitely the easiest first implementation.

Ideally, xdiff could return how many lines the input string has. So we can 
preallocate. But it's not in the current xdiff API.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2602

To: quark, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to