indygreg added inline comments.

INLINE COMMENTS

> osutil.c:125
>  static PyObject *listdir_stat_getitem(PyObject *self, PyObject *key) {
> -     long index = PyInt_AsLong(key);
> +     long index = PyLong_AsLong(key);
>       if (index == -1 && PyErr_Occurred()) {

Is this valid for Python 2? The passed argument will likely be a PyInt on 
Python 2. I thought `PyLong_AsLong` only operates on int types?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2696

To: durin42, #hg-reviewers
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to