indygreg added inline comments. INLINE COMMENTS
> durin42 wrote in request.py:31 > I'm a little uncomfortable with this not advertising that it's not a hash > table, and htat lookups are O(N). Maybe send a docstring followup? I agree with the sentiment about this being a list in disguise. One reason I didn't bother to optimize it is because I don't think we do any `qsparams` lookups in loops and I don't believe we have any more than ~10 arguments to any single request. So even if we have an `O(n^2)` situation, n is so small that it doesn't matter. I can add a follow-up comment easily enough. Or we could just index the fields by key. That doesn't seem too difficult. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2776 To: indygreg, #hg-reviewers, durin42 Cc: av6, martinvonz, durin42, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
