yuja added inline comments. INLINE COMMENTS
> wireprotoframing.py:318 > + # Formatting string must be UTF-8. > + formatting = formatting.decode(r'utf-8', r'replace').encode(r'utf-8') > + It's probably better to require everything in ASCII if `formatting` is supposed to be fed to `_()`. It's a disaster to mix utf-8 bytes and local-encoding bytes in codebase. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2872 To: indygreg, #hg-reviewers, durin42 Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
