yuja added a comment.
> except for `encoding._wide`. I am not sure what your expectation is for
that.
> I don't think it would make sense to silently disable the extension if
> `encoding._wide` is set; IMO that would cause user confusion.
I think that's also true for `encoding != 'UTF-8'`. The simplest solution
would be to show a warning when loading the extension.
def extsetup(ui):
if encoding.encoding != 'UTF-8' or encoding._wide:
ui.warn(_('unsupported encoding or terminal setting\n'))
return
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3665
To: johnstiles, #hg-reviewers
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
