johnstiles (John Stiles) <phabrica...@mercurial-scm.org> writes:

> johnstiles added a comment.
>
>
>   Hi there @indygreg and @yuja  -- are you happy with the diff as it 
> currently stands? Do you think this needs any additional work?

Sorry for the late reply; was having email filtering issues (hopefully
fixed now).

Overall, I'm +0 on it because I think the "real" solution to this is to
templatize the graph glpyhs so any user could use whatever unicode they
desire. However, that's a tall order I wouldn't put on you so I'm fine
with putting this in and adding a note along the lines of, "the path to
get this in core is to get the graph log templated."

The only hiccup I keep having is the misalignment of graphs like these:

Do you think there's any way to fix those? I suspect the answer is "no"
unless someone wants to write their own font?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to