yuja added a comment.

  > +        if not opts.get('no_commit'):
  >  +            lock = repo.lock()
  >  +            tr = repo.transaction('import')
  >  +            dsguard = util.nullcontextmanager()
  >  +        else:
  >  +            lock = util.nullcontextmanager()
  >  +            tr = util.nullcontextmanager()
  >  +            dsguard = dirstateguard.dirstateguard(repo, 'import')
  >  +        with lock, tr, dsguard:
  
  Doesn't it leave a stale `lock` if `repo.transaction()` raises exception?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3748

To: martinvonz, #hg-reviewers
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[email protected]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to