indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
I'm getting a few test errors applying this against the latest revision of
`hg` repo:
--- /Users/gps/src/hg-committed/tests/test-check-commit.t
+++ /Users/gps/src/hg-committed/tests/test-check-commit.t.err
@@ -25,3 +25,10 @@
> fi
> done
> fi
+ Revision 82a9045ac1a2 does not comply with rules
+ ------------------------------------------------------
+ 1225: adds double empty line
+ +
+ 1419: adds double empty line
+ +
+
--- /Users/gps/src/hg-committed/tests/test-check-module-imports.t
+++ /Users/gps/src/hg-committed/tests/test-check-module-imports.t.err
@@ -43,3 +43,5 @@
> -X tests/test-lock.py \
> -X tests/test-verify-repo-operations.py \
> | sed 's-\\-/-g' | $PYTHON "$import_checker" -
+ hgext/beautifygraph.py:17: imports from mercurial not lexically sorted:
graphmod < templatekw
+ [1]
--- /Users/gps/src/hg-committed/tests/test-check-code.t
+++ /Users/gps/src/hg-committed/tests/test-check-code.t.err
@@ -12,9 +12,13 @@
> -X hgext/fsmonitor/pywatchman \
> -X mercurial/thirdparty \
> | sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false
+ hgext/beautifygraph.py:9:
+ > '''beautify log -G output by using Unicode characters (EXPERIMENTAL)
+ trailing whitespace
Skipping i18n/polib.py it has no-che?k-code (glob)
Skipping mercurial/statprof.py it has no-che?k-code (glob)
Skipping tests/badserverext.py it has no-che?k-code (glob)
+ [1]
File "$TESTTMP/printrevset.py", line 31, in printrevset
ui.write(smartset.prettyformat(revs) + b'\n')
AttributeError: 'module' object has no attribute 'prettyformat'
Please rebase this against the latest Mercurial revision, fix the static
analysis failures, and resubmit.
You should be able to test via: `cd tests; ./run-tests.py -l -j4
test-check-commit.t test-check-module-imports.t test-check-code.t
test-glog-beautifygraph.t`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3665
To: johnstiles, #hg-reviewers, spectral, indygreg
Cc: quark, spectral, indygreg, smf, yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
