pulkit added a comment.
Sorry for getting late to review this. Found a minor nit and also looks like you missed adding tests for bookmark movement and phase preservation. INLINE COMMENTS > closehead.py:55 > + > + if not revs: > + raise error.Abort(_('no revisions specified')) revs can be passed as opts['rev'] too now. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3557 To: joerg.sonnenberger, #hg-reviewers Cc: indygreg, pulkit, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel